mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.
Date Thu, 31 Jan 2019 02:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/#review212474
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 8119 (patched)
<https://reviews.apache.org/r/69872/#comment298229>

    Let's do the injection before passing it into `updateOperation`.


- Chun-Hung Hsiao


On Jan. 31, 2019, 2:44 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69872/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2019, 2:44 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Operations sent to a resource provider may include an OperationID
> in addition to an Operation UUID.  The UUID is sufficient to uniquely
> identify the operation, so it is possible for the resource provider
> to omit the OperationID in its responses to the agent.
> 
> This commit lets the agent fill in any missing ID before updates
> are acted upon, such as being sent to the master.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 0182dd2ca326723e96eef8c072696ad3c873de0b 
> 
> 
> Diff: https://reviews.apache.org/r/69872/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 11692.
> 
> I can probably repurpose that test, if we don't have a CREATE_DISK + feedback test already.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message