mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69869: [WIP] Added test for tearing down frameworks while creating disks.
Date Thu, 31 Jan 2019 01:38:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69869/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

The CREATE_DISK and DESTROY_DISK operations are "non-speculative"
operations, which means the master must wait for the operations to
complete successfully before the master can update its resources.
Because the master must wait to update the results of non-speculative
operations, it is possible for the framework making the
CREATE/DESTROY_DISK to be torn down before the operation completes.

This commit adds a test to make sure the master can gracefully handle
such a case.


Diffs
-----

  src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb 


Diff: https://reviews.apache.org/r/69869/diff/1/


Testing
-------

The test does not currently pass, as it is meant to be a regression
test for MESOS-9542 (a bug which has not been started yet).

src/mesos-tests --gtest_filter="SlaveTest.FrameworkTeardownBeforeTerminalOperationStatusUpdate"
--verbose


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message