mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.
Date Wed, 30 Jan 2019 22:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedbacks, so
MESOS-9537 would be triggered when an outstanding `UPDATE_STATE` call
from the resource provider races with an offer operation.


Diffs
-----

  src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
  src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377



Diff: https://reviews.apache.org/r/69866/diff/1/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message