mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <>
Subject Re: Review Request 69839: Fixed scheduler library on multiple SUBSCRIBE requests per connection.
Date Wed, 30 Jan 2019 04:34:39 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 30, 2019, 4:34 a.m.)

Review request for mesos, Alexander Rukletsov and Vinod Kone.

Bugs: MESOS-9210

Repository: mesos

Description (updated)

The HTTP scheduler API dictates that on a single connection, the
scheduler may only send a single SUBSCRIBE request. Due to recent
authentication related changes, this contract got broken. This patch
restores the contract and adds a test validating that the library is
enforcing it.

Diffs (updated)

  src/scheduler/scheduler.cpp cb24ba9c8e1d04b8c62bdf07b12758a61b3bf036 
  src/tests/scheduler_tests.cpp b571bb1d20744b943580677a26db4c12c7c311d1 




manual testing; 
Running the included test without patching `scheduler.cpp` -> fails as the master does
in fact receive two SUBSCRIBE requests.

`make check`


Till Toenshoff

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message