mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69818: Added minimal allocatable resources to framework information.
Date Tue, 29 Jan 2019 16:20:48 GMT


> On Jan. 29, 2019, 4:09 a.m., Benjamin Mahler wrote:
> > include/mesos/mesos.proto
> > Lines 1519 (patched)
> > <https://reviews.apache.org/r/69818/diff/1/?file=2121448#file2121448line1519>
> >
> >     I'm not sure if this gives much information to the reader, thoughts on the following?
> >     
> >     ```
> >     /**
> >      * Represents filters that allow a framework to control the
> >      * shape of offers that will be sent to its role(s). These
> >      * filters apply globally to any agent (unlike the existing
> >      * `DECLINE` filter, which is a time based resource subset
> >      * filter that only applies to the agent that was declined).
> >      */
> >     ```

I thought about something like that as well, but there is nothing in the allocator interface
enforcing it, e.g., an allocator could just ignore this information.

I'd suggest to not make promises here where it isn't much more than a container.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212401
-----------------------------------------------------------


On Jan. 29, 2019, 5:20 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2019, 5:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds minimal allocatable resources to a framework's
> `FrameworkInfo`. We introduce a dedicated type to model allocatable
> resources which is composed of types loosly based on the internal
> `ResourceQuantity` class.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429 
>   include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033 
>   src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd 
>   src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f 
> 
> 
> Diff: https://reviews.apache.org/r/69818/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message