mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69819: Added equality operator for `ResourceQuantities`.
Date Tue, 29 Jan 2019 16:20:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69819/
-----------------------------------------------------------

(Updated Jan. 29, 2019, 5:20 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Rebased.


Bugs: MESOS-9523
    https://issues.apache.org/jira/browse/MESOS-9523


Repository: mesos


Description
-------

This patch adds an `operator==` for `ResourceQuantities`. The operator
is declared as a `friend` of `ResourceQuantities` so we can directly
compare the two `ResourceQuantities::quantities` which can be less
expensive.


Diffs (updated)
-----

  src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd 
  src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f 


Diff: https://reviews.apache.org/r/69819/diff/2/

Changes: https://reviews.apache.org/r/69819/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message