mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69818: Added minimal allocatable resources to framework information.
Date Tue, 29 Jan 2019 16:20:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------

(Updated Jan. 29, 2019, 5:20 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Addressed comments from Ben.


Bugs: MESOS-9523
    https://issues.apache.org/jira/browse/MESOS-9523


Repository: mesos


Description
-------

This patch adds minimal allocatable resources to a framework's
`FrameworkInfo`. We introduce a dedicated type to model allocatable
resources which is composed of types loosly based on the internal
`ResourceQuantity` class.


Diffs (updated)
-----

  include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429 
  include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033 
  src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd 
  src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f 


Diff: https://reviews.apache.org/r/69818/diff/2/

Changes: https://reviews.apache.org/r/69818/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message