mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.
Date Tue, 29 Jan 2019 13:21:08 GMT


> On Jan. 28, 2019, 9:37 p.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 9469-9491 (patched)
> > <https://reviews.apache.org/r/69680/diff/1/?file=2118289#file2118289line9469>
> >
> >     Can you use the mock RP's `operationDefault` method to accomplish this?
> >     
> >     https://github.com/apache/mesos/blob/d838f2958e18c1a75594ca4f10df132670fcd11e/src/tests/master_tests.cpp#L9200-L9201

This mock method needed to send a update UUID which I added in https://reviews.apache.org/r/69854/.

I also tried to make this us a non-speculated operation like `CREATE_DISK` instead of `RESERVE`
which caused me to run into https://issues.apache.org/jira/browse/MESOS-9542.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69680/#review212392
-----------------------------------------------------------


On Jan. 29, 2019, 2:21 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69680/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2019, 2:21 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-9434
>     https://issues.apache.org/jira/browse/MESOS-9434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After a framework was removed and has unacknowledged operations status
> updates, it was impossible to remove terminal operations as nobody could
> acknowledge them.
> 
> In this patch we make the master acknowledge operation status updates
> for frameworks it knows are removed so that e.g., terminal operations
> can be removed. Since masters do not persist completed frameworks this
> is not reliable (e.g., an agent was partitioned for a long time and
> still tracks a completed framework's `FrameworkInfo`, and comes back
> only after the master knowing about the framework's completion has
> failed over). We merely extend the existing master behavior (e.g., send
> `ShutdownFrameworkMessage` to all currently registered agents) to
> operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915 
>   src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 
> 
> 
> Diff: https://reviews.apache.org/r/69680/diff/2/
> 
> 
> Testing
> -------
> 
> * `make check`
> * tested on a number of configurations in internal CI
> * ran added test in repetition, both with and without additional stress
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message