mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69827: Exposed `StorageLocalResourceProviderProcess` for testing purpose.
Date Tue, 29 Jan 2019 05:43:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69827/
-----------------------------------------------------------

(Updated Jan. 29, 2019, 5:43 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Adjusted header inclusions for the SLRP header. Also fixed a compile error on GCC 4.8.5, and
made `__call` always dispatched as a general terminal signal of a CSI call for testing.


Bugs: MESOS-9517
    https://issues.apache.org/jira/browse/MESOS-9517


Repository: mesos


Description
-------

This patch moves the declaration of the SLRP process into an internal
header file and add a `__call` function, so a follow-up test could use
`FUTURE_DISPATCH` to capture a dispatch on an RPC retry.

To simplify the declarations, it also internalizes `RPCTraits` and
introduce new type aliases, and moves `DEFAULT_CSI_RETRY_BACKOFF_FACTOR`
and `DEFAULT_CSI_RETRY_INTERVAL_MAX` to the new header for testing.


Diffs (updated)
-----

  src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
  src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 
  src/csi/rpc.hpp c30a5091b0daedb58bc93385cf236ad93fef721d 
  src/resource_provider/storage/provider.hpp 331f7b785b14b814c2889488effd53f3a48a1b95 
  src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
  src/resource_provider/storage/provider_process.hpp PRE-CREATION 
  src/tests/csi_client_tests.cpp 3d4a0626c1d60e723487f99aee26d92064f82298 


Diff: https://reviews.apache.org/r/69827/diff/3/

Changes: https://reviews.apache.org/r/69827/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message