mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.
Date Mon, 28 Jan 2019 20:37:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69680/#review212392
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Line 8623 (original), 8623 (patched)
<https://reviews.apache.org/r/69680/#comment298153>

    For the sake of readability, I have a slight preference for:
    
    ```
      bool frameworkWillAcknowledge =
        operation->info().has_id() &&
        !isCompletedFramework(frameworkId.get());
    ```
    
    but not a big deal, feel free to drop this one if you disagree.



src/tests/master_tests.cpp
Lines 9330-9331 (patched)
<https://reviews.apache.org/r/69680/#comment298154>

    I might reword this comment as follows:
    
    "Tests that the master acknowledges reliably-sent operation status updates when the framework
that requested feedback for that operation has been torn down."



src/tests/master_tests.cpp
Lines 9336 (patched)
<https://reviews.apache.org/r/69680/#comment298155>

    I think this may not be necessary? `StartMaster()` should call it under the hood when
no flags are passed.



src/tests/master_tests.cpp
Lines 9453-9454 (patched)
<https://reviews.apache.org/r/69680/#comment298156>

    I would move this comment above the `mesos.reset();` line.



src/tests/master_tests.cpp
Lines 9469-9491 (patched)
<https://reviews.apache.org/r/69680/#comment298157>

    Can you use the mock RP's `operationDefault` method to accomplish this?
    
    https://github.com/apache/mesos/blob/d838f2958e18c1a75594ca4f10df132670fcd11e/src/tests/master_tests.cpp#L9200-L9201


- Greg Mann


On Jan. 7, 2019, 12:25 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69680/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2019, 12:25 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-9434
>     https://issues.apache.org/jira/browse/MESOS-9434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After a framework was removed and has unacknowledged operations status
> updates, it was impossible to remove terminal operations as nobody could
> acknowledge them.
> 
> In this patch we make the master acknowledge operation status updates
> for frameworks it knows are removed so that e.g., terminal operations
> can be removed. Since masters do not persist completed frameworks this
> is not reliable (e.g., an agent was partitioned for a long time and
> still tracks a completed framework's `FrameworkInfo`, and comes back
> only after the master knowing about the framework's completion has
> failed over). We merely extend the existing master behavior (e.g., send
> `ShutdownFrameworkMessage` to all currently registered agents) to
> operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69680/diff/1/
> 
> 
> Testing
> -------
> 
> * `make check`
> * tested on a number of configurations in internal CI
> * ran added test in repetition, both with and without additional stress
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message