mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.
Date Sat, 26 Jan 2019 00:17:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69811/
-----------------------------------------------------------

(Updated Jan. 26, 2019, 12:17 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comment.


Bugs: MESOS-9517
    https://issues.apache.org/jira/browse/MESOS-9517


Repository: mesos


Description
-------

This patch refactors the `StorageLocalResourceProvider::call` function
to obtain the latest service future through `getService` before making
the actual RPC call. The subsequent patch would utilize this to support
RPC retry across plugin restarts.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 


Diff: https://reviews.apache.org/r/69811/diff/3/

Changes: https://reviews.apache.org/r/69811/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message