mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69827: Exposed `StorageLocalResourceProviderProcess` for testing purpose.
Date Fri, 25 Jan 2019 20:45:40 GMT


> On Jan. 25, 2019, 4:56 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 21 (original)
> > <https://reviews.apache.org/r/69827/diff/1/?file=2121814#file2121814line21>
> >
> >     Haven't audited all the includes, but we still seem to use types from the headers
removed here below (e.g., `std::shared_ptr` or `std::vector`, probably more). Since these
headers aren't included in `storage/provider.hpp` we should include them here.
> 
> Chun-Hung Hsiao wrote:
>     It's included in `provider_process.hpp`. Basically I moved all necessary headers
for defining `StorageLocalResourceProviderProcess` into the new header, and added missing
inclusions. Should I also add them back here, at least for the ones with `using` declarations?

We usually accept includes from the corresponding header, here `provider.hpp`. Since depending
on another header is pretty intransparent and hard to discover I'd make sure this TU includes
everything it needs if it isn't already included by `provider.hpp`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69827/#review212324
-----------------------------------------------------------


On Jan. 24, 2019, 7:08 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69827/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2019, 7:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9517
>     https://issues.apache.org/jira/browse/MESOS-9517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch moves the declaration of the SLRP process into an internal
> header file and add a `__call` function, so a follow-up test could use
> `FUTURE_DISPATCH` to capture a dispatch on an RPC retry.
> 
> To simplify the declarations, it also internalizes `RPCTraits` and
> introduce new type aliases, and moves `CSI_RETRY_BACKOFF_FACTOR` and
> `CSI_RETRY_INTERVAL_MAX` to the SLRP process since these constants are
> only used by the now-exposed actor.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 
>   src/csi/rpc.hpp c30a5091b0daedb58bc93385cf236ad93fef721d 
>   src/resource_provider/storage/provider.hpp 331f7b785b14b814c2889488effd53f3a48a1b95

>   src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c

>   src/resource_provider/storage/provider_process.hpp PRE-CREATION 
>   src/tests/csi_client_tests.cpp 3d4a0626c1d60e723487f99aee26d92064f82298 
> 
> 
> Diff: https://reviews.apache.org/r/69827/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message