mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69787: Added a forwarding mode to the test CSI plugin.
Date Fri, 25 Jan 2019 16:32:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69787/#review212331
-----------------------------------------------------------


Fix it, then Ship it!





src/examples/test_csi_plugin.cpp
Lines 1197-1210 (original), 1231-1244 (patched)
<https://reviews.apache.org/r/69787/#comment298093>

    Did you intend to introduce some runtime polymorphism here? Either that, or put `proxy`
and `plugin` on the stack.


- Benjamin Bannier


On Jan. 25, 2019, 1:35 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69787/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2019, 1:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9517
>     https://issues.apache.org/jira/browse/MESOS-9517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the `--forward` flag is set, the test CSI plugin would forward all gRPC
> requests to the specified gRPC server URI, and return the response to
> the caller. This can be used to forward all CSI calls to a mock CSI
> plugin object in the test process.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_plugin.cpp af183037b280bab65578a4c447196a9ccf261e32 
> 
> 
> Diff: https://reviews.apache.org/r/69787/diff/3/
> 
> 
> Testing
> -------
> 
> Manually tweaked the plugin to forward requests to itself and all tests pass.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message