mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69082: Correctly propagated `close` failures in some instances.
Date Thu, 24 Jan 2019 10:30:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/
-----------------------------------------------------------

(Updated Jan. 24, 2019, 11:30 a.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Alex Clemmer.


Changes
-------

Addressed some more comments from bmahler.


Bugs: MESOS-9331
    https://issues.apache.org/jira/browse/MESOS-9331


Repository: mesos


Description
-------

When e.g., writing to disk, errors from write might only manifest at
::close time. We update some instances to correctly propagate these
errors instead of dropping them silently. We only propagate the
::close error if the write operation succeeded, otherwise we just
propagate the error from the write operation.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/mktemp.hpp 63b3d1a7720d07f877fa1d4eb7f32a548916637a

  3rdparty/stout/include/stout/os/write.hpp f7538f94f5a953a7a90a05bc1d2f138b6c17f814 
  3rdparty/stout/include/stout/protobuf.hpp eb4adef56f1701e3c101284e05e4e6c66eef9180 


Diff: https://reviews.apache.org/r/69082/diff/4/

Changes: https://reviews.apache.org/r/69082/diff/3-4/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message