mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69825: Added test to ensure backwards compatibility of resources checkpointing.
Date Thu, 24 Jan 2019 07:46:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/#review212265
-----------------------------------------------------------




src/tests/reservation_tests.cpp
Lines 2517 (patched)
<https://reviews.apache.org/r/69825/#comment298003>

    Is this necessary? I didn't think the master needed to be initialized with roles anymore?



src/tests/reservation_tests.cpp
Lines 2580 (patched)
<https://reviews.apache.org/r/69825/#comment298004>

    s/processses/processes/


- Greg Mann


On Jan. 23, 2019, 6:26 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69825/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2019, 6:26 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
>     https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test to ensure backwards compatibility of resources checkpointing.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547 
> 
> 
> Diff: https://reviews.apache.org/r/69825/diff/1/
> 
> 
> Testing
> -------
> 
> The test passed 10,000 consecutive runs.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message