mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69813: Improved error printing for gRPC statuses.
Date Thu, 24 Jan 2019 06:09:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/
-----------------------------------------------------------

(Updated Jan. 24, 2019, 6:09 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Implemented the output operator for `StatusCode` instead. This could be used to generate metric
names.


Bugs: MESOS-9517
    https://issues.apache.org/jira/browse/MESOS-9517


Repository: mesos


Description
-------

This patch prepends the error message of a `process::grpc::StatusError`
with its status code.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7 
  3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc 


Diff: https://reviews.apache.org/r/69813/diff/2/

Changes: https://reviews.apache.org/r/69813/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message