mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69794: Made agent checkpoint operations affecting default resources.
Date Wed, 23 Jan 2019 23:27:25 GMT


> On Jan. 23, 2019, 2:07 p.m., Greg Mann wrote:
> > src/slave/paths.hpp
> > Lines 377-378 (patched)
> > <https://reviews.apache.org/r/69794/diff/1/?file=2120587#file2120587line377>
> >
> >     Nit: fits on one line.

I didn't change this one for consistency with most of the rest of the file... but if you really
want to join these lines, I can do it =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69794/#review212206
-----------------------------------------------------------


On Jan. 23, 2019, 3:23 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69794/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2019, 3:23 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
>     https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the agent atomically checkpoint resoures and operations
> affecting agent default resources. This is needed in order to provide
> operation feedback for operations affecting agent default resources.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp 73b94a8df932e40d4f266de01150bb17c2282f22 
>   src/slave/paths.cpp 0ec50d052e29577818e828133a3c501cacf6f2e0 
>   src/slave/slave.hpp 2bcd7a93a8f25b77c71c7f931bfaac87649f987c 
>   src/slave/slave.cpp ed92f672f5155d70a36ba3619bb6f06fa09bc836 
>   src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 
> 
> 
> Diff: https://reviews.apache.org/r/69794/diff/3/
> 
> 
> Testing
> -------
> 
> Current tests still pass.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message