mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68018: Added `SeccompFilter` class.
Date Mon, 14 Jan 2019 08:31:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68018/#review211946
-----------------------------------------------------------




src/linux/seccomp/seccomp.cpp
Lines 137-139 (patched)
<https://reviews.apache.org/r/68018/#comment297515>

    Will this affect the task run by Mesos? E.g., a task may want to run a program which has
`set-user-ID` bit.



src/linux/seccomp/seccomp.cpp
Lines 148 (patched)
<https://reviews.apache.org/r/68018/#comment297516>

    s/ContainerSeccompProfile_Architecture_Name/ContainerSeccompProfile::Architecture_Name/



src/linux/seccomp/seccomp.cpp
Lines 224 (patched)
<https://reviews.apache.org/r/68018/#comment297517>

    s/ContainerSeccompProfile_Syscall_Action_Name/ContainerSeccompProfile::Syscall::Action_Name/


- Qian Zhang


On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68018/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2018, 11:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9034
>     https://issues.apache.org/jira/browse/MESOS-9034
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `SeccompFilter` class is a wrapper for `libseccomp` API. Its main
> purpose is to provide a translation of the `ContainerSeccompProfile`
> message into calls of `libseccomp` API.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/linux/seccomp/seccomp.hpp PRE-CREATION 
>   src/linux/seccomp/seccomp.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68018/diff/14/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message