mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.
Date Fri, 11 Jan 2019 14:24:28 GMT


> On Jan. 10, 2019, 8:53 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Line 8954 (original), 8982-8984 (patched)
> > <https://reviews.apache.org/r/69669/diff/1/?file=2117537#file2117537line8982>
> >
> >     Nit: fits on one line.

I'm curious, do we have an (informal) guideline that says when things fit on one line we should
try to fit them there?

I actually intentionally spread this out, because I found my eyes were skipping over this
line while reading, and due to that I was wondering why we only loop over `slave->resourceProviders`
below.


> On Jan. 10, 2019, 8:53 p.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 5127 (patched)
> > <https://reviews.apache.org/r/69669/diff/1/?file=2117538#file2117538line5127>
> >
> >     Since we don't reference the contents of `slaveFlags` anywhere, you can omit
this variable; `StartSlave()` will use the default argument value of `None()` and create the
slave flags itself before calling `cluster::Slave::create()`.

Dropping this since we have to use the `slaveFlags` when pausing the clock in this test.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69669/#review211836
-----------------------------------------------------------


On Jan. 11, 2019, 2:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69669/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2019, 2:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8783
>     https://issues.apache.org/jira/browse/MESOS-8783
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent is being marked as unreachable due to missing
> the reregistration timeout, all operations on that agent
> are implicilty transitioned to status `OPERATION_UNREACHABLE`.
> 
> This commit adds an explicit notification for this transition
> to frameworks which opted-in to operation feedback.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 8de73124dbfb81d6edd0d1d5193adc21756f3fad 
>   src/master/master.cpp 9624832d017dae717da803ca2ff2f8fc5135ea9d 
>   src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 
> 
> 
> Diff: https://reviews.apache.org/r/69669/diff/2/
> 
> 
> Testing
> -------
> 
> Internal CI run.
> 
> `./src/mesos-tests --gtest_filter="*OperationUpdatesUponUnreachable*" --verbose --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message