mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.
Date Fri, 11 Jan 2019 14:24:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69669/
-----------------------------------------------------------

(Updated Jan. 11, 2019, 2:24 p.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Joseph Wu.


Changes
-------

Address comments and rebase onto latest master.


Bugs: MESOS-8783
    https://issues.apache.org/jira/browse/MESOS-8783


Repository: mesos


Description
-------

When an agent is being marked as unreachable due to missing
the reregistration timeout, all operations on that agent
are implicilty transitioned to status `OPERATION_UNREACHABLE`.

This commit adds an explicit notification for this transition
to frameworks which opted-in to operation feedback.


Diffs (updated)
-----

  src/master/master.hpp 8de73124dbfb81d6edd0d1d5193adc21756f3fad 
  src/master/master.cpp 9624832d017dae717da803ca2ff2f8fc5135ea9d 
  src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 


Diff: https://reviews.apache.org/r/69669/diff/2/

Changes: https://reviews.apache.org/r/69669/diff/1-2/


Testing (updated)
-------

Internal CI run.

`./src/mesos-tests --gtest_filter="*OperationUpdatesUponUnreachable*" --verbose --gtest_repeat=5000`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message