mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.
Date Thu, 10 Jan 2019 20:53:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69669/#review211836
-----------------------------------------------------------




src/master/master.cpp
Line 8954 (original), 8982-8984 (patched)
<https://reviews.apache.org/r/69669/#comment297419>

    Nit: fits on one line.



src/tests/api_tests.cpp
Lines 5127 (patched)
<https://reviews.apache.org/r/69669/#comment297420>

    Since we don't reference the contents of `slaveFlags` anywhere, you can omit this variable;
`StartSlave()` will use the default argument value of `None()` and create the slave flags
itself before calling `cluster::Slave::create()`.



src/tests/api_tests.cpp
Lines 5161-5164 (patched)
<https://reviews.apache.org/r/69669/#comment297421>

    I think this variable is unused?



src/tests/api_tests.cpp
Lines 5203-5204 (patched)
<https://reviews.apache.org/r/69669/#comment297424>

    Let's get rid of the parentheses:
    
    "Try to reserve the resources managed by the resource provider, because currently operation
feedback is only supported for that case."



src/tests/api_tests.cpp
Lines 5236-5239 (patched)
<https://reviews.apache.org/r/69669/#comment297426>

    Could we just pause the clock for the whole test? It might be necessary to retain the
`slaveFlags` variable if you do this.
    
    We should also resume the clock at the end of the test.


- Greg Mann


On Jan. 4, 2019, 4:57 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69669/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2019, 4:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8783
>     https://issues.apache.org/jira/browse/MESOS-8783
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent is being marked as unreachable due to missing
> the reregistration timeout, all operations on that agent
> are implicilty transitioned to status `OPERATION_UNREACHABLE`.
> 
> This commit adds an explicit notification for this transition
> to frameworks which opted-in to operation feedback.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 99549ab857b16d722f0dd991f98dbe54e9ed19a1 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
>   src/tests/api_tests.cpp b6064cd749e42e45c2b471c71e9769a41b59f726 
> 
> 
> Diff: https://reviews.apache.org/r/69669/diff/1/
> 
> 
> Testing
> -------
> 
> Internal CI run.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message