mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69662: Displayed resource provider information in the Mesos webui.
Date Thu, 10 Jan 2019 09:24:37 GMT


> On Jan. 9, 2019, 11:19 p.m., Chun-Hung Hsiao wrote:
> > src/webui/app/controllers.js
> > Lines 697 (patched)
> > <https://reviews.apache.org/r/69662/diff/4/?file=2118370#file2118370line697>
> >
> >     Instead of setting `agent.resource_providers` with `state.resource_providers`
and mutating each item, how about initializing it to `{}` and constructing each item one by
one, like what we do for `agent.frameworks`, for consistency?

Done. I didn't go for an extra function since IMO there is little gain ATM.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211802
-----------------------------------------------------------


On Jan. 10, 2019, 10:19 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2019, 10:19 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8380
>     https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Displayed resource provider information in the Mesos webui.
> 
> 
> Diffs
> -----
> 
>   src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 
>   src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/69662/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran a local test with a `./src/test-csi-plugin`.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot Agent screen
>   https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
>   https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
>   https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message