mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69662: Displayed resource provider information in the Mesos webui.
Date Mon, 07 Jan 2019 21:02:26 GMT


> On Jan. 7, 2019, 7:14 p.m., Benjamin Mahler wrote:
> > src/webui/app/agents/agent.html
> > Lines 176-179 (patched)
> > <https://reviews.apache.org/r/69662/diff/2/?file=2117505#file2117505line176>
> >
> >     Is this hidden if there are no providers? Can you show a screenshot of the entire
agent UI rather than just a cropped version? One where there are no providers would be helpful
as well (my inclination is to hide it in that case)

Hiding the table now if no resource providers are present.

During the transition period this might be confusing to users since it is hard to tell whether
their UI does not display any resource providers, or if no resource providers are present,
but hiding it is the right long-term solution and I believe acceptable for an experimental
feature.


> On Jan. 7, 2019, 7:14 p.m., Benjamin Mahler wrote:
> > src/webui/app/agents/agent.html
> > Lines 184-186 (patched)
> > <https://reviews.apache.org/r/69662/diff/2/?file=2117505#file2117505line184>
> >
> >     Do we actually expect resource providers to be providing cpus and mem? I would
suggest removing these to simplify the UI
> >     
> >     Maybe at some point we want to show other resource names being provided? Maybe
the column should just be 'Resources' and a stringified version is shown?

re:stringification, I am hesitant to put a stringified resource string into `/state`, and
we currently do not provide a resource stringification function in the webui javascript code.
As writing one would be a bigger undertaking (e.g., requiring extensive testing to ensure
the javascript implementation stays in sync with what we use in Mesos), I'd prefer to punt
on that for now; I could also imagine that we would eventually want a resource representation
which exposes more low-level information (for SLRPs resources e.g., the individual disks and
their metadata).

I am just exposing aggregated `disk` resources in the UI now since only storage resource providers
are currently implemented (which I gratuitously assert only provide `disk` resources). I tried
to add a `console.warn` to the controller code so that it warns should other resource kinds
show up, but this is not allowed by the linter (and maybe not a good idea, either).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211732
-----------------------------------------------------------


On Jan. 7, 2019, 10:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2019, 10:02 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8380
>     https://issues.apache.org/jira/browse/MESOS-8380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Displayed resource provider information in the Mesos webui.
> 
> 
> Diffs
> -----
> 
>   src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 
>   src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/69662/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran a local test with a `./src/test-csi-plugin`.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot Agent screen
>   https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
>   https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message