mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69671: Always build gRPC with its embedded c-ares.
Date Mon, 07 Jan 2019 20:18:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69671/
-----------------------------------------------------------

(Updated Jan. 7, 2019, 8:18 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed Jie's comment.


Bugs: MESOS-9505
    https://issues.apache.org/jira/browse/MESOS-9505


Repository: mesos


Description
-------

We compile gRPC with its embedded c-ares library to avoid a link error
because Mesos is not aware of the library.


Diffs (updated)
-----

  3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87 


Diff: https://reviews.apache.org/r/69671/diff/2/

Changes: https://reviews.apache.org/r/69671/diff/1-2/


Testing
-------

make check with c-ares pre-installed on mac and ubuntu.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message