mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69600: Added tests for `ResourceQuantities`.
Date Sat, 05 Jan 2019 23:50:13 GMT


> On Jan. 4, 2019, 2:03 p.m., Benjamin Mahler wrote:
> > src/tests/resource_quantities_tests.cpp
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/69600/diff/3/?file=2117695#file2117695line41>
> >
> >     How about FromStringValid?

Done.


> On Jan. 4, 2019, 2:03 p.m., Benjamin Mahler wrote:
> > src/tests/resource_quantities_tests.cpp
> > Lines 113-115 (patched)
> > <https://reviews.apache.org/r/69600/diff/3/?file=2117695#file2117695line113>
> >
> >     Can you also add a section to test that "nan", "-nan", "inf", "-inf", "infinity",
"-infinity" are disallowed?
> >     
> >     I think they will go through, so we probably have to update values::parse

Done.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69600/#review211694
-----------------------------------------------------------


On Jan. 5, 2019, 3:50 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69600/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2019, 3:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added parsing and insertion tests for `ResourceQuantities`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/tests/CMakeLists.txt c588183e9d2b1cc733fdf3df70f37d47a5fdd7c0 
>   src/tests/resource_quantities_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69600/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message