mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69673: Disallowed nan, inf and so on when parsing Value::Scalar.
Date Sat, 05 Jan 2019 23:49:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69673/
-----------------------------------------------------------

(Updated Jan. 5, 2019, 3:49 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Added more tests.


Repository: mesos


Description
-------

Scalar values are intended to be finite numbers. This
patch checks `nan`, `inf` and so on when parsing
`Value::Scalar`. Only normal or zero numbers (as defined
in `std::fpclassify()`) are allowed.

Also added related tests.


Diffs (updated)
-----

  src/common/values.cpp f04d115d2651da5a2784cb9e76757ecef9e2c118 
  src/tests/values_tests.cpp e4fcf982ac385f58e602eca78765f85485194e41 
  src/v1/values.cpp 1be99459ef8eb427b44f87234d64ebf099cd7866 


Diff: https://reviews.apache.org/r/69673/diff/2/

Changes: https://reviews.apache.org/r/69673/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message