mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 69671: Always build gRPC with its embedded c-ares.
Date Sat, 05 Jan 2019 01:31:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69671/#review211701
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/Makefile.am
Lines 500 (patched)
<https://reviews.apache.org/r/69671/#comment297209>

    Can you add some comments about this one? Or just separate this change in a different
patch?


- Jie Yu


On Jan. 5, 2019, 1:24 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69671/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2019, 1:24 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9505
>     https://issues.apache.org/jira/browse/MESOS-9505
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We compile gRPC with its embedded c-ares library to avoid a link error
> because Mesos is not aware of the library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87 
> 
> 
> Diff: https://reviews.apache.org/r/69671/diff/1/
> 
> 
> Testing
> -------
> 
> make check with c-ares pre-installed on mac and ubuntu.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message