mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69601: Added a `Resources` method `contains(ResourceQuantities)`.
Date Fri, 04 Jan 2019 20:16:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69601/
-----------------------------------------------------------

(Updated Jan. 4, 2019, 12:16 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

This method checks if the quantities of this `Resources` is a
superset of the given `ResourceQuantities`. If a `Resource` object
is `SCALAR` type, its quantity is its scalar value. For `RANGES`
and `SET` type, their quantities are the number of different
instances in the range or set. For example, "range:[1-5]" has a
quantity of 5 and "set:{a,b}" has a quantity of 2.

Also added a dedicated test.


Diffs (updated)
-----

  include/mesos/resources.hpp 36ccf0e1135ce15898d31db51c80fa7b5826907b 
  include/mesos/v1/resources.hpp 1a9ea44e78d985286e04e040879d022838ddcc3f 
  src/common/resources.cpp 758b5a2fac101bfb0a07ba76c204b02d1554b3ac 
  src/tests/resources_tests.cpp 5337a5c9af9431cc1c7822c78945ffc369488900 
  src/v1/resources.cpp d717f5327a45cfe9bc075bc3acf37316223d389d 


Diff: https://reviews.apache.org/r/69601/diff/3/

Changes: https://reviews.apache.org/r/69601/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message