mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 69667: Sent SIGKILL to I/O switchboard server as a safeguard.
Date Fri, 04 Jan 2019 16:19:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69667/#review211676
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp
Lines 817 (patched)
<https://reviews.apache.org/r/69667/#comment297131>

    Add a comment for posterity.
    
    // If we are here, something really bad must have happened for I/O switchboard server
    // to not exit after SIGTERM has been sent. We have seen this happen due to FD leak (See:
MESOS-9502).
    // We do a SIGKILL here as a safeguard, so that switchboard server forcefully exits and
causes this
    // cleanup feature to be completed, thus unblocking the container's cleanup.


- Vinod Kone


On Jan. 4, 2019, 8:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69667/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2019, 8:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7042
>     https://issues.apache.org/jira/browse/MESOS-7042
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Sent SIGKILL to I/O switchboard server as a safeguard.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp c445a8f09d7671d5763281bac9881489b3cc9c39

> 
> 
> Diff: https://reviews.apache.org/r/69667/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message