mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.
Date Thu, 03 Jan 2019 05:16:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69656/
-----------------------------------------------------------

Review request for mesos, Joseph Wu and Till Toenshoff.


Bugs: MESOS-5048
    https://issues.apache.org/jira/browse/MESOS-5048


Repository: mesos


Description
-------

`MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is flaky
due to a race between executor shutdown (due to never getting any
tasks) and the test querying resource statistics. If the executor
is shutdown before the statistics query, the test will fail.

This patch fixes the test by explicitly waiting for the task to
be delivered and task status transition to `TASK_RUNNING` before
restarting the agent. This way, the executor will not be shutdown
after agent restart. Hence there will be no race.


Diffs
-----

  src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 


Diff: https://reviews.apache.org/r/69656/diff/1/


Testing
-------

ran `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` continuously without failure.


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message