mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68017: Added Seccomp-related protobuf messages.
Date Wed, 02 Jan 2019 19:51:56 GMT


> On Dec. 13, 2018, 12:20 a.m., Gilbert Song wrote:
> > include/mesos/slave/containerizer.proto
> > Lines 200-215 (patched)
> > <https://reviews.apache.org/r/68017/diff/10/?file=2109592#file2109592line200>
> >
> >     I saw you remove all `SCMP_` prefix and implemented a hashmap converter in the
next patch. You do this for `AUDIT_` architecture on pupose?
> 
> Andrei Budnik wrote:
>     Adding `SCMP_` prefix leads to compilation errors due to interference with libseccomp's
constants.

Probably we should add some comments for getting rid of the `SCMP_` prefix (since people may
ask the same question):

// `SCMP_` prefix is not included in `enum` due to compilation conflicts with libseccomp constants.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68017/#review211264
-----------------------------------------------------------


On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68017/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2018, 7:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9033
>     https://issues.apache.org/jira/browse/MESOS-9033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d 
>   include/mesos/slave/containerizer.proto 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 
>   include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb 
> 
> 
> Diff: https://reviews.apache.org/r/68017/diff/11/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message