mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69447: Improved wording in comments for `AgentAdded` event.
Date Wed, 02 Jan 2019 11:28:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69447/#review211602
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 26, 2018, 6:44 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69447/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2018, 6:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The comment mentioned that `AgentAdded` events can be
> sent when an agent reregisters after a master failover.
> This is technically correct, but neglects to mention
> that the event can also be sent when the agent reregisters
> at any other point in time.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 
>   include/mesos/v1/master/master.proto cd41a7e8dc98753b5d2b8f93d92114fe97463636 
> 
> 
> Diff: https://reviews.apache.org/r/69447/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message