From reviews-return-84041-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Dec 12 20:47:56 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C7E518D22 for ; Wed, 12 Dec 2018 20:47:56 +0000 (UTC) Received: (qmail 64893 invoked by uid 500); 12 Dec 2018 20:47:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64860 invoked by uid 500); 12 Dec 2018 20:47:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64849 invoked by uid 99); 12 Dec 2018 20:47:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2018 20:47:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7339CC0026; Wed, 12 Dec 2018 20:47:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.064 X-Spam-Level: * X-Spam-Status: No, score=1.064 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.114, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id yRH3IYkIao2p; Wed, 12 Dec 2018 20:47:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DC11160F89; Wed, 12 Dec 2018 20:47:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1C6DDE00D4; Wed, 12 Dec 2018 20:47:52 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DF5EFC400FF; Wed, 12 Dec 2018 20:47:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6082723054957419944==" MIME-Version: 1.0 Subject: Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members. From: Benno Evers To: Joseph Wu , Alexander Rukletsov Cc: mesos , Benno Evers Date: Wed, 12 Dec 2018 20:47:51 -0000 Message-ID: <20181212204751.46709.45@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69071/ X-Sender: Benno Evers References: <20181122011923.23128.83575@reviews-vm2.apache.org> In-Reply-To: <20181122011923.23128.83575@reviews-vm2.apache.org> Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============6082723054957419944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/ ----------------------------------------------------------- (Updated Dec. 12, 2018, 8:47 p.m.) Review request for mesos, Alexander Rukletsov and Joseph Wu. Changes ------- Rebased onto latest master again. Repository: mesos Description (updated) ------- Previously, the members of ReadOnlyHandler would take a full Request as parameter, making it hard for clients to reason about which parts of the request are used internally, and even harder to guarantee that behaviour into the future. This commit changes the interface so only the query parameters get passed. Diffs (updated) ----- src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85 src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29 Diff: https://reviews.apache.org/r/69071/diff/3/ Changes: https://reviews.apache.org/r/69071/diff/2-3/ Testing ------- Thanks, Benno Evers --===============6082723054957419944==--