| Gilbert Song |
Re: Review Request 68016: Added libseccomp to the build. |
Mon, 17 Dec, 19:09 |
| Chun-Hung Hsiao |
Re: Review Request 69569: Added missing code to set resource provider and agent ids. |
Mon, 17 Dec, 19:11 |
| Chun-Hung Hsiao |
Re: Review Request 69569: Added missing code to set resource provider and agent ids. |
Mon, 17 Dec, 19:11 |
| Benjamin Bannier |
Re: Review Request 69569: Added missing code to set resource provider and agent ids. |
Mon, 17 Dec, 19:15 |
| Chun-Hung Hsiao |
Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`. |
Mon, 17 Dec, 20:20 |
| Mesos Reviewbot |
Re: Review Request 69082: Correctly propagated `close` failures in some instances. |
Mon, 17 Dec, 21:52 |
| Greg Mann |
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members. |
Mon, 17 Dec, 21:58 |
| Chun-Hung Hsiao |
Re: Review Request 69572: Validated that resource providers use correct ID in operation states. |
Mon, 17 Dec, 22:28 |
| Chun-Hung Hsiao |
Re: Review Request 69572: Validated that resource providers use correct ID in operation states. |
Mon, 17 Dec, 22:33 |
| Greg Mann |
Re: Review Request 68795: Added deduplication for read-only master requests. |
Mon, 17 Dec, 22:46 |
| Chun-Hung Hsiao |
Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`. |
Mon, 17 Dec, 22:58 |
| Chun-Hung Hsiao |
Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly. |
Mon, 17 Dec, 23:00 |
| Benno Evers |
Review Request 69575: WIP: Send operation feedback when agent is marked as gone. |
Mon, 17 Dec, 23:08 |
| Mesos Reviewbot Windows |
Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly. |
Tue, 18 Dec, 00:02 |
| Greg Mann |
Re: Review Request 69421: Exposed private data members for testing. |
Tue, 18 Dec, 00:49 |
| Mesos Reviewbot Windows |
Re: Review Request 69575: WIP: Send operation feedback when agent is marked as gone. |
Tue, 18 Dec, 01:24 |
| Benno Evers |
Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members. |
Tue, 18 Dec, 01:24 |
| Chun-Hung Hsiao |
Review Request 69577: Documented `Object.value` authorization field for certain operations. |
Tue, 18 Dec, 06:13 |
| Chun-Hung Hsiao |
Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `REMOVE_DISK` authorization. |
Tue, 18 Dec, 06:14 |
| Gilbert Song |
Re: Review Request 68018: Added `SeccompFilter` class. |
Tue, 18 Dec, 07:18 |
| Mesos Reviewbot Windows |
Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `REMOVE_DISK` authorization. |
Tue, 18 Dec, 07:57 |
| Qian Zhang |
Re: Review Request 69544: Made non-root containers can access shared persistent volume. |
Tue, 18 Dec, 08:08 |
| Qian Zhang |
Re: Review Request 69543: Implemented recovery for volume gid manager. |
Tue, 18 Dec, 08:09 |
| Qian Zhang |
Re: Review Request 69541: Added volume gid manager. |
Tue, 18 Dec, 08:11 |
| Qian Zhang |
Re: Review Request 69543: Implemented recovery for volume gid manager. |
Tue, 18 Dec, 08:12 |
| Qian Zhang |
Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. |
Tue, 18 Dec, 08:25 |
| Greg Mann |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Tue, 18 Dec, 08:32 |
| Greg Mann |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Tue, 18 Dec, 08:32 |
| Greg Mann |
Re: Review Request 69422: WIP: Add new metric for cache hits. |
Tue, 18 Dec, 08:34 |
| Greg Mann |
Review Request 69581: Fixed an interleaving bug on the master actor. |
Tue, 18 Dec, 09:06 |
| Greg Mann |
Review Request 69582: Added a test to verify a bug fix for the master. |
Tue, 18 Dec, 09:08 |
| Mesos Reviewbot Windows |
Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. |
Tue, 18 Dec, 09:35 |
| Mesos Reviewbot Windows |
Re: Review Request 69582: Added a test to verify a bug fix for the master. |
Tue, 18 Dec, 11:10 |
| Andrei Budnik |
Re: Review Request 68016: Added libseccomp to the build. |
Tue, 18 Dec, 13:31 |
| Mesos Reviewbot Windows |
Re: Review Request 69493: Documented the `linux/seccomp` isolator. |
Tue, 18 Dec, 13:32 |
| Benjamin Bannier |
Re: Review Request 69572: Validated that resource providers use correct ID in operation states. |
Tue, 18 Dec, 14:12 |
| Qian Zhang |
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty libraries. |
Tue, 18 Dec, 14:24 |
| Benno Evers |
Review Request 69584: Relaxed matching criteria for benchmark filter. |
Tue, 18 Dec, 14:41 |
| Jan Schlicht |
Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`. |
Tue, 18 Dec, 14:49 |
| Jan Schlicht |
Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly. |
Tue, 18 Dec, 14:51 |
| Till Toenshoff via Review Board |
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script. |
Tue, 18 Dec, 14:51 |
| Benno Evers |
Re: Review Request 69584: Relaxed matching criteria for test filters. |
Tue, 18 Dec, 14:59 |
| Mesos Reviewbot Windows |
Re: Review Request 69572: Validated that resource providers use correct ID in operation states. |
Tue, 18 Dec, 15:54 |
| Andrei Budnik |
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty libraries. |
Tue, 18 Dec, 16:33 |
| Benjamin Bannier |
Re: Review Request 69577: Documented `Object.value` authorization field for certain operations. |
Tue, 18 Dec, 17:03 |
| Benjamin Bannier |
Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `DESTROY_DISK` authorization. |
Tue, 18 Dec, 17:13 |
| Andrei Budnik |
Re: Review Request 69541: Added volume gid manager. |
Tue, 18 Dec, 18:04 |
| Andrei Budnik |
Re: Review Request 69543: Implemented recovery for volume gid manager. |
Tue, 18 Dec, 18:26 |
| Benno Evers |
Re: Review Request 68795: Added deduplication for read-only master requests. |
Tue, 18 Dec, 18:33 |
| Benno Evers |
Re: Review Request 69422: Added new metric for cache hits. |
Tue, 18 Dec, 18:41 |
| Benno Evers |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Tue, 18 Dec, 18:41 |
| Benno Evers |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Tue, 18 Dec, 18:42 |
| Meng Zhu |
Re: Review Request 69584: Relaxed matching criteria for test filters. |
Tue, 18 Dec, 18:44 |
| Joseph Wu |
Re: Review Request 69584: Relaxed matching criteria for test filters. |
Tue, 18 Dec, 19:21 |
| Chun-Hung Hsiao |
Re: Review Request 69577: Documented `Object.value` authorization field for certain operations. |
Tue, 18 Dec, 20:33 |
| Chun-Hung Hsiao |
Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `DESTROY_DISK` authorization. |
Tue, 18 Dec, 21:24 |
| Chun-Hung Hsiao |
Re: Review Request 69581: Fixed an interleaving bug on the master actor. |
Tue, 18 Dec, 21:46 |
| Gastón Kleiman |
Re: Review Request 69581: Fixed an interleaving bug on the master actor. |
Tue, 18 Dec, 22:44 |
| Deepak Goel |
Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 00:12 |
| Till Toenshoff via Review Board |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 00:48 |
| Deepak Goel |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 02:03 |
| Deepak Goel |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 02:05 |
| Qian Zhang |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 02:51 |
| Deepak Goel |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 03:25 |
| Chun-Hung Hsiao |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 04:35 |
| Chun-Hung Hsiao |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 04:37 |
| Chun-Hung Hsiao |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 04:41 |
| Deepak Goel |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 04:52 |
| Deepak Goel |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 04:53 |
| Jie Yu |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 05:37 |
| Qian Zhang |
Re: Review Request 69590: Moves CNI root directory to a persistent location. |
Wed, 19 Dec, 06:07 |
| Meng Zhu |
Review Request 69591: Fixed allocator benchmark names to ensure proper filtering. |
Wed, 19 Dec, 06:11 |
| Deepak Goel |
Review Request 69592: Updated upgrades.md. |
Wed, 19 Dec, 07:22 |
| Qian Zhang |
Re: Review Request 69592: Updated upgrades.md. |
Wed, 19 Dec, 07:33 |
| Greg Mann |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Wed, 19 Dec, 08:34 |
| Greg Mann |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Wed, 19 Dec, 08:34 |
| Benno Evers |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Wed, 19 Dec, 12:08 |
| Benno Evers |
Re: Review Request 69584: Relaxed matching criteria for test filters. |
Wed, 19 Dec, 12:20 |
| Benno Evers |
Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering. |
Wed, 19 Dec, 12:24 |
| GitBox |
[GitHub] abudnik opened a new pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency. |
Wed, 19 Dec, 15:15 |
| GitBox |
[GitHub] jpeach closed pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency. |
Wed, 19 Dec, 16:18 |
| Till Toenshoff via Review Board |
Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering. |
Wed, 19 Dec, 17:04 |
| Benno Evers |
Re: Review Request 69575: Send operation feedback when agent was marked as gone. |
Wed, 19 Dec, 17:51 |
| Benno Evers |
Review Request 69597: Remove outstanding operations when removing agents. |
Wed, 19 Dec, 17:52 |
| Benno Evers |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Wed, 19 Dec, 18:39 |
| Benno Evers |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Wed, 19 Dec, 18:39 |
| Chun-Hung Hsiao |
Review Request 69588: Removed outdated authorization logic for offer operations. |
Wed, 19 Dec, 19:38 |
| Benjamin Mahler |
Re: Review Request 69588: Removed outdated authorization logic for offer operations. |
Wed, 19 Dec, 20:15 |
| Benno Evers |
Re: Review Request 69584: Relaxed matching criteria for test filters. |
Wed, 19 Dec, 22:00 |
| Chun-Hung Hsiao |
Re: Review Request 69588: Removed outdated authorization logic for offer operations. |
Wed, 19 Dec, 23:20 |
| Meng Zhu |
Review Request 69599: Added a new class `ResourceQuantities`. |
Thu, 20 Dec, 00:09 |
| Meng Zhu |
Review Request 69600: Added tests for class `Quantity` and `ResourceQuantities`. |
Thu, 20 Dec, 00:10 |
| Meng Zhu |
Review Request 69601: Added a `Resources` method `contains(ResourceQuantities)`. |
Thu, 20 Dec, 00:10 |
| Benjamin Mahler |
Re: Review Request 69557: Tested framework subscription with set but empty ID. |
Thu, 20 Dec, 00:59 |
| Benjamin Mahler |
Re: Review Request 69398: Added validation for framework IDs. |
Thu, 20 Dec, 01:01 |
| Qian Zhang |
Re: Review Request 69541: Added volume gid manager. |
Thu, 20 Dec, 01:35 |
| Qian Zhang |
Re: Review Request 69543: Implemented recovery for volume gid manager. |
Thu, 20 Dec, 01:36 |
| Meng Zhu |
Review Request 69603: Extended `min_allocatable_resources` flag to cover non-scalar resources. |
Thu, 20 Dec, 07:00 |
| Greg Mann |
Re: Review Request 69064: Added unit tests for Master HTTP endpoints. |
Thu, 20 Dec, 09:32 |
| Qian Zhang |
Re: Review Request 68016: Added libseccomp to the build. |
Thu, 20 Dec, 09:39 |