mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68020: Added Seccomp-related flags to the agent.
Date Thu, 27 Dec 2018 07:44:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68020/#review211537
-----------------------------------------------------------




docs/configuration/agent.md
Lines 1645-1646 (patched)
<https://reviews.apache.org/r/68020/#comment296862>

    Should we move this note into the description of `--seccomp_profile_name`?



docs/configuration/agent.md
Lines 1655 (patched)
<https://reviews.apache.org/r/68020/#comment296863>

    Should it be `Path of the default Seccomp profile`?



docs/configuration/agent.md
Lines 1659 (patched)
<https://reviews.apache.org/r/68020/#comment296864>

    What's the behavior differece between this flag specified with an empty value and this
flag not specified at all?



src/slave/flags.hpp
Lines 192 (patched)
<https://reviews.apache.org/r/68020/#comment296866>

    Why not make this flag as optional too?


- Qian Zhang


On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68020/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2018, 11:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `--seccomp_config_dir` and `--seccomp_profile_name` flags have been
> added to the agent. These flags are used by the `linux/seccomp`
> isolator to specify the path of the directory containing Seccomp
> profiles and the path of the default Seccomp profile.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 
>   src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
>   src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 
> 
> 
> Diff: https://reviews.apache.org/r/68020/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message