mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69064: Added unit tests for Master HTTP endpoints.
Date Wed, 19 Dec 2018 08:34:03 GMT


> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote:
> > src/tests/master_load_tests.cpp
> > Lines 555 (patched)
> > <https://reviews.apache.org/r/69064/diff/4/?file=2113358#file2113358line555>
> >
> >     Can you use some other header to test this case, so that we don't need to disable
the test? You could even set an arbitrary header which is not interpreted by libprocess.
> 
> Benno Evers wrote:
>     The endpoints themselves will ignore all headers, so the idea of this test was to
verify that libprocess can still correctly handle the headers that libprocess cares about.
So using another header which is ignored by libprocess will not really work for that purpose.
>     
>     I suppose we could drop the test completely, but I think the chances are pretty low
that we will remember (and allocate time) to write this test from scratch in the future, when
it becomes possible to enable it.

Could you elaborate on the reason for the test? I don't quite understand why we need a test
to verify that libprocess can still correctly handle some headers? I was thinking that the
test was trying to verify that de-duplication was working correctly in cases where requests
differ only in the headers that they specify, but it doesn't look like that's what the body
of the test is doing.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69064/#review211377
-----------------------------------------------------------


On Dec. 18, 2018, 6:41 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69064/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2018, 6:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a set of unit test to verify that
> basic Master HTTP endpoints still work correctly
> under the presence of request caching.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa 
>   src/tests/master_load_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69064/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message