mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69422: WIP: Add new metric for cache hits.
Date Tue, 18 Dec 2018 08:34:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69422/#review211387
-----------------------------------------------------------


Ship it!




I would advocate integrating this with the tests now. I think we can just assert that cache
hits have occurred; if the test fails for this reason, then it's flaky and should be fixed
or disabled.

- Greg Mann


On Dec. 12, 2018, 8:54 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69422/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2018, 8:54 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The idea was to use this in unit tests as well as for
> benchmarks to verify that caching actually happens.
> 
> However, it's currently not integrated into the unit test
> because it's unclear what should happen in case the test
> detects that no caching occurred.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
>   src/master/metrics.hpp f6bb89da9394bfe469bc690ff2de66824e994098 
>   src/master/metrics.cpp f69ed52c1c89912e7a5d26cb9409f5959b09111a 
> 
> 
> Diff: https://reviews.apache.org/r/69422/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message