mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69064: Added unit tests for Master HTTP endpoints.
Date Tue, 18 Dec 2018 08:32:56 GMT


> On Nov. 26, 2018, 12:25 p.m., Benno Evers wrote:
> > src/tests/master_load_tests.cpp
> > Lines 216 (patched)
> > <https://reviews.apache.org/r/69064/diff/3/?file=2109726#file2109726line216>
> >
> >     I'm not 100% happy about this part, but I also couldn't think of a better way
to generate the references. Any ideas/comments?

No brilliant ideas here - as long as the structure of these responses is completed encoded
within the HTTP handlers themselves, I'm not sure that we have any choice. Feel free to drop
this issue.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69064/#review210858
-----------------------------------------------------------


On Dec. 12, 2018, 8:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69064/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2018, 8:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a set of unit test to verify that
> basic Master HTTP endpoints still work correctly
> under the presence of request caching.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 35500516e18ff251357b9e8d6bba894c44a9253b 
>   src/tests/master_load_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69064/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message