mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 68795: Added deduplication for read-only master requests.
Date Mon, 17 Dec 2018 22:46:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68795/#review211373
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp
Lines 2385-2395 (patched)
<https://reviews.apache.org/r/68795/#comment296379>

    Could you add a comment here which notes that this is effectively adding a layer of authorization
permissions caching? Since we don't directly compare equality of approvers (which seems difficult
to accomplish), we only check for equality of the principal, which implies that the permissions
for the principal have remained constant.
    
    I think this is fine because in most cases the deferred requests will be satisfied relatively
quickly, but in the case of a heavily-loaded master this implicit "caching timeout" could
grow to seconds in duration. Let's be explicit about this and note it in a comment.


- Greg Mann


On Dec. 12, 2018, 8:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68795/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2018, 8:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change will skip the computation of an HTTP response
> for requests with the same principal, endpoint and request
> headers where both requests are authenticated within the
> same batching windows.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
>   src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85 
> 
> 
> Diff: https://reviews.apache.org/r/68795/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message