-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/#review211370
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Dec. 12, 2018, 8:47 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69071/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2018, 8:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the members of ReadOnlyHandler would take a full Request as parameter, making
it hard for clients to reason about which parts of the request are used internally, and even
harder to guarantee that behaviour into the future.
>
> This commit changes the interface so only the query parameters get passed.
>
>
> Diffs
> -----
>
> src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937
> src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85
> src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29
>
>
> Diff: https://reviews.apache.org/r/69071/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
|