mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69338: Change agent to not report disconnected resource providers.
Date Fri, 14 Dec 2018 15:56:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69338/
-----------------------------------------------------------

(Updated Dec. 14, 2018, 4:56 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9384
    https://issues.apache.org/jira/browse/MESOS-9384


Repository: mesos


Description
-------

This patch changes the agent to not report disconnected resource
providers in the `UpdateSlaveMessage` it emits. We also fix how it
generates resource provider-related updates when no resource providers
are connected to allow the master to react properly when a resource
provider disappears.


Diffs (updated)
-----

  src/slave/slave.cpp 8467a60ad84a4e900c2eb587fdf2fc6ff9c72c54 
  src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe 


Diff: https://reviews.apache.org/r/69338/diff/3/

Changes: https://reviews.apache.org/r/69338/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message