mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69337: Garbage collected disappeared resource providers from master state.
Date Fri, 14 Dec 2018 15:56:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69337/
-----------------------------------------------------------

(Updated Dec. 14, 2018, 4:56 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9384
    https://issues.apache.org/jira/browse/MESOS-9384


Repository: mesos


Description
-------

The master previously kept information on resource providers
indefinitely. This was confusing to API users who saw resource
providers reported which where not present anymore, and also made it
harder to derive actual cluster state.

With this patch we remove resource providers not reported by the agent
from master state. We still need to update the agent to not report
removed resource providers in a follow-up patch.


Diffs (updated)
-----

  src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c 
  src/messages/messages.proto 41e6a8a2eab0ae7c2878c1d3286c5dea0eb68ed7 


Diff: https://reviews.apache.org/r/69337/diff/3/

Changes: https://reviews.apache.org/r/69337/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message