mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69338: Change agent to not report disconnected resource providers.
Date Thu, 13 Dec 2018 23:40:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69338/#review211312
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 7664 (patched)
<https://reviews.apache.org/r/69338/#comment296300>

    Can you add a comment for `UpdateSlaveMessage.resource_providers` in `src/messages/messages.proto`,
e.g.,
    ```
    If not set, it means that the resource providers on this agent remain unchanged.
    ```
    And maybe add a corresonding comment in `src/master/master.cpp`, like here:
    https://reviews.apache.org/r/69337/#comment296301
    
    Also, there's a typo ("resoruces") in the comment of `update_oversubscribed_resources`.



src/slave/slave.cpp
Line 7592 (original), 7671 (patched)
<https://reviews.apache.org/r/69338/#comment296299>

    s/informat on/information/ ;)


- Chun-Hung Hsiao


On Dec. 13, 2018, 1:51 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69338/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2018, 1:51 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9384
>     https://issues.apache.org/jira/browse/MESOS-9384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the agent to not report disconnected resource
> providers in the `UpdateSlaveMessage` it emits. We also fix how it
> generates resource provider-related updates when no resource providers
> are connected to allow the master to react properly when a resource
> provider disappears.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 8467a60ad84a4e900c2eb587fdf2fc6ff9c72c54 
>   src/tests/resource_provider_manager_tests.cpp b61c50f839b7a0f49a781a6f44aa4f10ad7ebafe

> 
> 
> Diff: https://reviews.apache.org/r/69338/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message