mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69521: Fixed `AgentResourceProviderConfigApiTest.Update` for `vendor` field.
Date Thu, 13 Dec 2018 22:18:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69521/
-----------------------------------------------------------

(Updated Dec. 13, 2018, 10:18 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments.


Summary (updated)
-----------------

Fixed `AgentResourceProviderConfigApiTest.Update` for `vendor` field.


Bugs: MESOS-9321
    https://issues.apache.org/jira/browse/MESOS-9321


Repository: mesos


Description
-------

The introduction of the `Resource.DiskInfo.Source.vendor` changes the
resource comparison and thus breaks this test. This patch fixes the test
and make it more robust.

NOTE: The updated test will fail unless the previous patch (which sets
up the `vendor` field) is also applied.


Diffs (updated)
-----

  src/tests/agent_resource_provider_config_api_tests.cpp 15c83b33505a7926d1069c97f808feb9626f81f0



Diff: https://reviews.apache.org/r/69521/diff/2/

Changes: https://reviews.apache.org/r/69521/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message