mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69521: Fixed test `AgentResourceProviderConfigApiTest.Update` for the `vendor` field.
Date Thu, 13 Dec 2018 22:17:47 GMT


> On Dec. 13, 2018, 12:15 p.m., Benjamin Bannier wrote:
> > src/tests/agent_resource_provider_config_api_tests.cpp
> > Lines 634-636 (patched)
> > <https://reviews.apache.org/r/69521/diff/1/?file=2112538#file2112538line635>
> >
> >     These need to be `ASSERT_TRUE` since we access the fields below.

These accessor function would return a default value if the field doesn't exist. But I agree
that `ASSERT_TRUE` makes more sense.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69521/#review211276
-----------------------------------------------------------


On Dec. 7, 2018, 4:35 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69521/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2018, 4:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9321
>     https://issues.apache.org/jira/browse/MESOS-9321
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The introduction of the `Resource.DiskInfo.Source.vendor` changes the
> resource comparison and thus breaks this test. This patch fixes the test
> and make it more robust.
> 
> NOTE: The updated test will fail unless the previous patch (which sets
> up the `vendor` field) is also applied.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_resource_provider_config_api_tests.cpp 15c83b33505a7926d1069c97f808feb9626f81f0

> 
> 
> Diff: https://reviews.apache.org/r/69521/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message