mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.
Date Thu, 13 Dec 2018 22:16:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69520/
-----------------------------------------------------------

(Updated Dec. 13, 2018, 10:16 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9321
    https://issues.apache.org/jira/browse/MESOS-9321


Repository: mesos


Description
-------

For a CSI-backed disk resource, this field is set to the concatenation
of the type and name of its CSI plugin, with a dot in between. This
enables frameworks to identify the storage backend the disk resource.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp c137fa4f13edc58d93c03a9dd32fdf9d38b38316 


Diff: https://reviews.apache.org/r/69520/diff/2/

Changes: https://reviews.apache.org/r/69520/diff/1-2/


Testing
-------

Testing done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message