mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.
Date Thu, 13 Dec 2018 12:16:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69522/#review211279
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/resources_tests.cpp
Line 2373 (original), 2373 (patched)
<https://reviews.apache.org/r/69522/#comment296240>

    Let's include `<tuple>` for this one.



src/tests/resources_tests.cpp
Lines 2375-2376 (original), 2375-2377 (patched)
<https://reviews.apache.org/r/69522/#comment296244>

    Not yours, but we could append small comments clarifying the different boolean parameters,
e.g.,
    ```
    bool, // Whether the disk has a set `vendor` field.
    bool, // Whether the disk has a set `id` field.
    bool>> {} // Whether the disk has a a set `profile` field.
    ```



src/tests/storage_local_resource_provider_tests.cpp
Lines 323-327 (patched)
<https://reviews.apache.org/r/69522/#comment296245>

    Since all inputs are constants I wonder why we couldn't just make this a constant as well,
e.g.,
    ```
    constexpr char TEST_CSI_VENDOR_NAME[] = "org.apache.mesos.csi.test.local";
    ```



src/tests/storage_local_resource_provider_tests.cpp
Lines 827 (patched)
<https://reviews.apache.org/r/69522/#comment296246>

    This is not a precondition for anything later and could just be an `EXPECT_EQ`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 872 (patched)
<https://reviews.apache.org/r/69522/#comment296247>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1581 (patched)
<https://reviews.apache.org/r/69522/#comment296248>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1844 (patched)
<https://reviews.apache.org/r/69522/#comment296249>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 2063 (patched)
<https://reviews.apache.org/r/69522/#comment296250>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 2670 (patched)
<https://reviews.apache.org/r/69522/#comment296251>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3511 (patched)
<https://reviews.apache.org/r/69522/#comment296252>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3789 (patched)
<https://reviews.apache.org/r/69522/#comment296253>

    Ditto.


- Benjamin Bannier


On Dec. 7, 2018, 5:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69522/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2018, 5:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9321
>     https://issues.apache.org/jira/browse/MESOS-9321
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested the `Resource.DiskInfo.Source.vendor` field in related tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp ab42374cfad74e3b0ba3eb8d7140fed1730d5d8b 
>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69522/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message