mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.
Date Thu, 13 Dec 2018 12:15:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69520/#review211277
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 251 (patched)
<https://reviews.apache.org/r/69520/#comment296234>

    Could we order `vendor` before `id` in the arg list?



src/resource_provider/storage/provider.cpp
Line 258 (original), 260 (patched)
<https://reviews.apache.org/r/69520/#comment296233>

    `static_cast<double>`



src/resource_provider/storage/provider.cpp
Lines 270 (patched)
<https://reviews.apache.org/r/69520/#comment296235>

    This is pretty dense, maybe instead
    ```
    if (vendor.isSome()) {
      source->set_vendor(vendor.get());
    } else {
      source->set_vendor(strings::join(
        ".", info.storage().plugin().type(), info.storage().plugin().name()));
    }
    ```
    
    Since this would be the third time we touch `source`, I think it would make sense to store
in in a variable and use it above and below.



src/resource_provider/storage/provider.cpp
Lines 1394 (patched)
<https://reviews.apache.org/r/69520/#comment296236>

    Why don't we have to worry about `has_vendor() == false` here?


- Benjamin Bannier


On Dec. 7, 2018, 5:34 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69520/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2018, 5:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9321
>     https://issues.apache.org/jira/browse/MESOS-9321
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For a CSI-backed disk resource, this field is set to the concatenation
> of the type and name of its CSI plugin, with a dot in between. This
> enables frameworks to identify the storage backend the disk resource.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp c137fa4f13edc58d93c03a9dd32fdf9d38b38316

> 
> 
> Diff: https://reviews.apache.org/r/69520/diff/1/
> 
> 
> Testing
> -------
> 
> Testing done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message