mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.
Date Thu, 13 Dec 2018 12:14:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69037/#review211281
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Lines 1467-1468 (patched)
<https://reviews.apache.org/r/69037/#comment296254>

    I wonder if we should even document this implementation (?) aspect. It doesn't seem to
add value.
    
    Also in v1.


- Benjamin Bannier


On Dec. 7, 2018, 5:31 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69037/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2018, 5:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9321
>     https://issues.apache.org/jira/browse/MESOS-9321
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new `vendor` field together with the `id` field provide the means of
> uniquely identifying a CSI volume upon a CSI plugin migration (e.g.,
> there is a change in the agent ID).
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 56107f47a46ac3679a57af0580c55ad0f98543f5 
>   include/mesos/v1/mesos.proto c6e7515a44eca0b057725c7b8196250072b56be5 
>   src/common/resources.cpp 1585e30ae9b8ba14b67deed33d67fa2d88576caa 
>   src/v1/resources.cpp 0248f1da650b4973d09eaab3cfbe5a113b5a447a 
> 
> 
> Diff: https://reviews.apache.org/r/69037/diff/2/
> 
> 
> Testing
> -------
> 
> Testing done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message