mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68795: Added deduplication for read-only master requests.
Date Wed, 12 Dec 2018 20:51:53 GMT


> On Nov. 30, 2018, 2:03 a.m., Joseph Wu wrote:
> > src/master/http.cpp
> > Lines 2392 (patched)
> > <https://reviews.apache.org/r/68795/diff/3/?file=2109719#file2109719line2392>
> >
> >     Micro nit: s/Note that this is/NOTE: This is/

Counter-nit: Would be cool to have these as issues, just so I get to click on 'Fixed' afterwards
;) Anyways, fixed.


> On Nov. 30, 2018, 2:03 a.m., Joseph Wu wrote:
> > src/master/http.cpp
> > Lines 2401 (patched)
> > <https://reviews.apache.org/r/68795/diff/3/?file=2109719#file2109719line2401>
> >
> >     You might want to leave a note here, or elsewhere, to state that only `BODY`
type Responses should be used here.  When we copy the `Future<Response>` to multiple
recipients, we effectively copy the `std::string body` that comprises the response text. 

> >     
> >     This might also work for `PATH` type responses, but since we'd be copying the
path to a file, we'd still be reading the same file twice.
> >     
> >     The `PIPE` response would be the one that should be avoided.  When you copy
the `Option<Pipe::Reader> reader`, this does not duplicate the stream.  So multiple
readers would each get separate parts of the stream, and neither would get a cohesive response
(or if lucky, one reader would read everything, and the other reader(s) would get nothing).

Added a comment in the header, in the hope that it's most visible there.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68795/#review210960
-----------------------------------------------------------


On Dec. 12, 2018, 8:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68795/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2018, 8:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change will skip the computation of an HTTP response
> for requests with the same principal, endpoint and request
> headers where both requests are authenticated within the
> same batching windows.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
>   src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85 
> 
> 
> Diff: https://reviews.apache.org/r/68795/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message